Painfully Obvious

Comments

1. Dean Edwards Mar 9th, 2007
   at 7:21 pm (Quote ↓)

   This looks like a very good release. The XPath parser looks awesome.

   Two things:

   1. Must you overwrite Array.prototype.concat?
   2. You site is very slow to load these days. 200K of script isn’t helping. ;-)
2. kourge Mar 9th, 2007
   at 10:32 pm (Quote ↓)

   There seems to be something weird about the title: this article is on 1.5.1rc1, right? But it’s titled 1.5.0rc1.

   It’s nice to see that there’s finally a centralized browser detection variable. That way there won’t be /Konqueror|Safari|KHTML/.test(navigator.userAgent) running all over the place.

   Way to go for the native JSON support! Although it might be safer for .toJSON(true) to be the default setting.

   I have to say this has nothing to do with 1.5.1_rc1, but I really really really want to see Event methods actually being extended on event objects that are passed to event handler functions. It’s painfully silly to do Event.stop(event).

3. Andrew Mar 10th, 2007
   at 12:52 am (Quote ↓)

   @Dean: Are you sure we overwrite Array.prototype.concat? I define Selector.handlers.concat for fast joining of DOM collections, but I don’t think we touch native array concatenation.

   And, yeah, I need to trim all the Scriptaculous stuff I don’t use on this site. Thanks for the prod.

   @Kourge: Yeah, I fucked up on the title of the post. And the events stuff you’re asking for is being worked on — there’s an “events” branch in trunk that holds the in-progress code.

4. Dean Edwards Mar 10th, 2007
   at 5:33 am (Quote ↓)

   My mistake. You overwrite Array.prototype.concat for Opera only. You do overwrite map though. Ignore my nitpickings, like I said this looks like a great release,

5. kourge Mar 11th, 2007
   at 4:54 pm (Quote ↓)

   Yup, found the event spinoff at Rails Trac. Awwwwwesome.